Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove needs triage label from new bug issues #39

Closed
wants to merge 1 commit into from

Conversation

OgDev-01
Copy link

Description

This PR removes the needs triage label from the bug issue template. This is causing some confusion with contributors waiting for the needs triage label to be removed in order to pick up an issue, even when the issue doesn’t need it

This label can be added manually when the bug has been evaluated and requires the need triage label

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@bdougie
Copy link
Member

bdougie commented Aug 25, 2023

We do need triage though. The label is meant for either the maintainers or triage team to know which issues need a comment.

I'd prefer a discussion before a PR to ensure we are taking contributions from folks who have context.

@OgDev-01
Copy link
Author

A lot of folks have reached out asking me to take off needs triage label in order for them to work on an issue, and the truth is that most of the bug issues don’t need triaging. IMO we can add the needs triage label to bugs that needs triage manually as opposed to automatically adding it when a bug issue is created. This label is causing some confusions with new contributors.

@bdougie
Copy link
Member

bdougie commented Aug 25, 2023

A lot of folks have reached out asking me to take off needs triage label in order for them to work on an issue, and the truth is that most of the bug issues don’t need triaging. IMO we can add the needs triage label to bugs that needs triage manually as opposed to automatically adding it when a bug issue is created. This label is causing some confusions with new contributors.

Sounds like we need more triagers then. I still by the quality of contribution is too low and any opensauced orgs members can remove the label.

We can solve this with education.

@jpmcb
Copy link
Member

jpmcb commented Aug 25, 2023

I agree with Brian, we should always try to have a conversation with outside contributors before a change is executed but I can also empathize with people showing up to make small, obvious changes. It can be confusing for them to understand our process if we don't clearly lay out our expectations. We should look at writing a doc or something for users to read to get up to speed on our labeling and triaging practices.

For example, in the past, I've written documents like this to clearly lay this out: spf13/cobra#1603

@bdougie bdougie closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants