fix: now using setQueryParams no longer causes page to jump #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zeucapua
approved these changes
Aug 2, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
## [2.50.0-beta.5](v2.50.0-beta.4...v2.50.0-beta.5) (2024-08-02) ### 🐛 Bug Fixes * now using setQueryParams no longer causes page to jump ([#3837](#3837)) ([6541971](6541971))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [2.50.0](v2.49.0...v2.50.0) (2024-08-06) ### 🍕 Features * 'Coming Soon' state for OSSF Scorecard ([#3840](#3840)) ([a36205a](a36205a)) * add option to import a SBOM of repositories to a workspace ([#3838](#3838)) ([ce6b783](ce6b783)) * added a skip link ([#3850](#3850)) ([83b335a](83b335a)) * converted contributor insight contributor table to new table component ([#3843](#3843)) ([c91211c](c91211c)) * OSCR works with API range 0-300 and uses ceiling math ([#3829](#3829)) ([23ae445](23ae445)) ### 🐛 Bug Fixes * **/app/pages/_document.tsx:** add lang attribute to html tag ([#3851](#3851)) ([d98bc0a](d98bc0a)) * now tooltip appears over lock button ([#3832](#3832)) ([b3274cb](b3274cb)) * now using setQueryParams no longer causes page to jump ([#3837](#3837)) ([6541971](6541971)) * OSCR math ceiling for contributor card ([#3839](#3839)) ([fc9b3e9](fc9b3e9)) * put back original heading for PR velocity ([#3830](#3830)) ([e8acd50](e8acd50)) * remove gradient from metadata tags ([#3856](#3856)) ([b446fc7](b446fc7)) * removed some unused code ([#3849](#3849)) ([70be5b9](70be5b9)) * removed unused code ([#3827](#3827)) ([3d28f2c](3d28f2c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now by default, if you use
setQueryParamsto added querystring parameters to the URL, the page no longer jumps. If for some reason you need it to scroll to the top, pass intrueforscroll.Related Tickets & Documents
Closes #3836
Mobile & Desktop Screenshots/Recordings
Before
After
Steps to QA
/u/nickytonlineTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?