Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a link to OSCR tooltips pointing to the OSCR docs #3921

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Aug 12, 2024

Description

Adds a link to the OSCR docs in OSCR info tooltips.

Related Tickets & Documents

Closes #3920

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-08-12 at 16 01 14

After

image

Note that the after screenshot is using our standard tooltip making it uniform with our other tootips.

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 0c92d15
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66ba6d1ce7c72d0008c9c00a
😎 Deploy Preview https://deploy-preview-3921--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 0c92d15
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66ba6d1c3766ec00088a6c0b
😎 Deploy Preview https://deploy-preview-3921--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from BekahHW and a team August 12, 2024 20:02
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks much more "squished" to my eyes and less appealing. Is there anything we can do to make it appear uniform to how it was before? The box also doesn't look rounded anymore. This seems to be a regression.


Before:

Screenshot 2024-08-12 at 2 07 26 PM

After:

Screenshot 2024-08-12 at 2 07 59 PM

@nickytonline
Copy link
Member Author

Note that the after screenshot is using our standard tooltip making it uniform with our other tootips.

Note that the after screenshot is using our standard tooltip making it uniform with our other tooltips. I can put it back to the same sizing.

@nickytonline
Copy link
Member Author

@jpmcb

CleanShot 2024-08-12 at 16 11 39

@jpmcb
Copy link
Member

jpmcb commented Aug 12, 2024

Note that the after screenshot is using our standard tooltip making it uniform with our other tooltips. I can put it back to the same sizing.

Gotcha - I had assumed the original had some special design behind it, but it seems not: #3857

Dealers choice!! 🃏

@nickytonline nickytonline enabled auto-merge August 12, 2024 20:13
@nickytonline nickytonline force-pushed the nickytonline/learn-more-oscr branch from bfb4c5f to 0c92d15 Compare August 12, 2024 20:14
@nickytonline nickytonline added this pull request to the merge queue Aug 12, 2024
Merged via the queue into beta with commit 71e8b4a Aug 12, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/learn-more-oscr branch August 12, 2024 20:25
open-sauced bot pushed a commit that referenced this pull request Aug 12, 2024
## [2.55.0-beta.1](v2.54.1-beta.1...v2.55.0-beta.1) (2024-08-12)

### 🍕 Features

* added a link to OSCR tooltips pointing to the OSCR docs ([#3921](#3921)) ([71e8b4a](71e8b4a))
open-sauced bot pushed a commit that referenced this pull request Aug 12, 2024
## [2.55.0](v2.54.0...v2.55.0) (2024-08-12)

### 🤖 Build System

* remove OpenGraph service environment variable ([#3915](#3915)) ([7c57ef0](7c57ef0))

### 🍕 Features

* added a link to OSCR tooltips pointing to the OSCR docs ([#3921](#3921)) ([71e8b4a](71e8b4a))

### 🐛 Bug Fixes

* re-enable newsletter form on Netlify ([#3919](#3919)) ([42e2668](42e2668))
* toggling hide bots for yolo coders no longer causes page jumps ([#3911](#3911)) ([4337ec3](4337ec3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a link to the OSCR docs in OSCR info tooltips
4 participants