fix: resolve incorrect redirect to 404 page on search fields #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 58819c8 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
changed the title
jpmcb
approved these changes
Aug 20, 2024
brandonroberts
requested changes
Aug 20, 2024
Co-authored-by: Brandon Roberts <[email protected]>
|
@brandonroberts sorry it took long to apply changes, I am quite new to open source, So I didn't knew what to do. |
|
@Mandeep56Singh no problem, thanks |
brandonroberts
approved these changes
Aug 22, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
## [2.60.0](v2.59.0...v2.60.0) (2024-08-22) ### 🐛 Bug Fixes * always show Add to Workspace button on repositories table ([#4003](#4003)) ([5954f32](5954f32)) * resolve incorrect redirect to 404 page on search fields ([#3959](#3959)) ([298161d](298161d)) ### 🍕 Features * copy OSSF Scorecard as image ([#4000](#4000)) ([690fb38](690fb38)) * copy repo page YOLO Chart as image ([#4014](#4014)) ([376dbe2](376dbe2)) * now you can copy the contributor confidence chart as an image ([#3966](#3966)) ([3291c6d](3291c6d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix : resolve incorrect redirect to 404 page on search fields
Closes #3949
Description
The search functionality in explore was redirecting users to a 404 error page
when they entered a query. This was caused by incorrect URL routing
in the search handle function
This commit fixes the routing logic by ensuring the search terms
are correctly encoded, thus preventing the 404 error.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
OpenSauced.Insights.-.Javascript._.Dashboard.-.Google.Chrome.2024-08-15.23-48-15.mp4
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?
Really sorry due to prettier some lines sorted unintentionally