Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make timezone optional for onboarding and user settings #3972

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

brandonroberts
Copy link
Contributor

Description

Makes timezone selection optional when onboarding or updating user settings

Related Tickets & Documents

Closes #3971

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@brandonroberts brandonroberts requested a review from a team August 16, 2024 16:35
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 7940c3c
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66c348a92ea2c30008ce73f6
😎 Deploy Preview https://deploy-preview-3972--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 7940c3c
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66c348a963ec16000852fb85
😎 Deploy Preview https://deploy-preview-3972--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Doesn't block, but since the onboarding says share your dev card, maybe share it right there instead of redirecting to the dev card page to do it?

CleanShot 2024-08-16 at 14 29 38

@brandonroberts
Copy link
Contributor Author

Updated the button to say Share Your DevCard which copies it to the clipboard

image

@brandonroberts brandonroberts added this pull request to the merge queue Aug 19, 2024
Merged via the queue into beta with commit f1795a3 Aug 19, 2024
13 checks passed
@brandonroberts brandonroberts deleted the fix-onboarding-timezone branch August 19, 2024 15:36
open-sauced bot pushed a commit that referenced this pull request Aug 19, 2024
## [2.59.0-beta.3](v2.59.0-beta.2...v2.59.0-beta.3) (2024-08-19)

### 🐛 Bug Fixes

* make timezone optional for onboarding and user settings ([#3972](#3972)) ([f1795a3](f1795a3))
open-sauced bot pushed a commit that referenced this pull request Aug 21, 2024
## [2.59.0](v2.58.0...v2.59.0) (2024-08-21)

### 🔁 Continuous Integration

* improve stability of E2E tests ([#3983](#3983)) ([7668b06](7668b06))

### 🍕 Features

* copy `LotteryFactorChart` as image ([#3987](#3987)) ([fa3255e](fa3255e))
* implement the CopyContainer component for copying it's contents as an image ([#3975](#3975)) ([cee5fa8](cee5fa8))

### 🐛 Bug Fixes

* add tooltip for long titles ([#3969](#3969)) ([e3404df](e3404df))
* adjust workspace upgrade pricing modal ([#3995](#3995)) ([798041a](798041a))
* make timezone optional for onboarding and user settings ([#3972](#3972)) ([f1795a3](f1795a3))
* reverted a file that accidentally went in cee5fa8 ([#3979](#3979)) ([d776a13](d776a13))
* Searching for a user/repository name throws error and crashes page ([#3980](#3980)) ([73f1c2c](73f1c2c))
* update PostHog SDK to latest version (1.152.7) ([#3996](#3996)) ([a5b7f3d](a5b7f3d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Make timezone selection optional
3 participants