-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make timezone optional for onboarding and user settings #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jpmcb
approved these changes
Aug 19, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
## [2.59.0-beta.3](v2.59.0-beta.2...v2.59.0-beta.3) (2024-08-19) ### 🐛 Bug Fixes * make timezone optional for onboarding and user settings ([#3972](#3972)) ([f1795a3](f1795a3))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
## [2.59.0](v2.58.0...v2.59.0) (2024-08-21) ### 🔁 Continuous Integration * improve stability of E2E tests ([#3983](#3983)) ([7668b06](7668b06)) ### 🍕 Features * copy `LotteryFactorChart` as image ([#3987](#3987)) ([fa3255e](fa3255e)) * implement the CopyContainer component for copying it's contents as an image ([#3975](#3975)) ([cee5fa8](cee5fa8)) ### 🐛 Bug Fixes * add tooltip for long titles ([#3969](#3969)) ([e3404df](e3404df)) * adjust workspace upgrade pricing modal ([#3995](#3995)) ([798041a](798041a)) * make timezone optional for onboarding and user settings ([#3972](#3972)) ([f1795a3](f1795a3)) * reverted a file that accidentally went in cee5fa8 ([#3979](#3979)) ([d776a13](d776a13)) * Searching for a user/repository name throws error and crashes page ([#3980](#3980)) ([73f1c2c](73f1c2c)) * update PostHog SDK to latest version (1.152.7) ([#3996](#3996)) ([a5b7f3d](a5b7f3d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes timezone selection optional when onboarding or updating user settings
Related Tickets & Documents
Closes #3971
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?