Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: spice up contributors pr chart styles #20

Merged
merged 33 commits into from
Jan 5, 2024
Merged

feat: spice up contributors pr chart styles #20

merged 33 commits into from
Jan 5, 2024

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Jan 3, 2024 •
edited
Loading

Description

This PR updates the styles of the chart and refactors the approach of data fetching. we now have a blend of serverside data fetching with client. this change removes the loading indicator from the application.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Desktop

image

Mobile

image

Steps to QA

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for contributor-info ready!

Name Link
🔨 Latest commit d5db2a0
🔍 Latest deploy log https://app.netlify.com/sites/contributor-info/deploys/65982f98c9b1ff00084bc32e
😎 Deploy Preview https://deploy-preview-20--contributor-info.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Jan 3, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@bdougie bdougie mentioned this pull request Jan 3, 2024
Merged
16 tasks
@bdougie
Copy link
Member

bdougie commented Jan 4, 2024

I got busy and did not run this locally yesterday but saw the error this morning.

Screen Shot 2024-01-04 at 5 56 27 AM

@bdougie
Copy link
Member

bdougie commented Jan 5, 2024

I got busy and did not run this locally yesterday but saw the error this morning.

I found and fixed the error 6444669

@bdougie bdougie mentioned this pull request Jan 5, 2024
Merged
16 tasks
@OgDev-01 OgDev-01 marked this pull request as ready for review January 5, 2024 14:34
@OgDev-01 OgDev-01 requested a review from bdougie January 5, 2024 14:34
@bdougie
Copy link
Member

bdougie commented Jan 5, 2024

Can you check https://deploy-preview-20--contributor-info.netlify.app/open-sauced/app

I get a client side exception

image

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Jan 5, 2024

Can you check deploy-preview-20--contributor-info.netlify.app/open-sauced/app

I get a client side exception

image

This works on my end, but the error may likely be cause by an undefined variable/function or an uncaught error from an async fetch call. Will take a closer look at this

bdougie
bdougie approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'd love to get this on beta and cut a release, but let me know if you want to continue to polishing this @OgDev-01

@OgDev-01
Copy link
Contributor Author

OgDev-01 commented Jan 5, 2024

but let me know if you want to continue to polishing this @OgDev-01

I'll merge this as is for now. Might do some playing around to refactoring and improve the data visualization during the weekend.

@OgDev-01 OgDev-01 merged commit bdf937f into beta Jan 5, 2024
10 checks passed
@OgDev-01 OgDev-01 deleted the ogdev/chart-component-rebuild branch January 5, 2024 17:19
open-sauced bot pushed a commit that referenced this pull request Jan 5, 2024
@OgDev-01 @open-sauced
chore(minor): release 1.1.0-beta.3 on beta channel [skip ci]
32e62fd 
## [1.1.0-beta.3](v1.1.0-beta.2...v1.1.0-beta.3) (2024-01-05)

### 🍕 Features

* spice up contributors pr chart styles ([#20](#20)) ([bdf937f](bdf937f))
open-sauced bot pushed a commit that referenced this pull request Jan 5, 2024
@bdougie @open-sauced
chore(minor): release 1.2.0-beta.1 on beta channel [skip ci]
dd16abf 
## [1.2.0-beta.1](v1.1.0...v1.2.0-beta.1) (2024-01-05)

### 🍕 Features

* Add a PR activity chart ([#19](#19)) ([9bac59a](9bac59a))
* spice up contributors pr chart styles ([#20](#20)) ([bdf937f](bdf937f))
* use v2 pr/search ([#16](#16)) ([f1f78ff](f1f78ff))
* Working Nivo chart ([#22](#22)) ([22c07a9](22c07a9))
open-sauced bot pushed a commit that referenced this pull request Jan 5, 2024
@bdougie @open-sauced
chore(minor): release 1.2.0 [skip ci]
7d994ab 
## [1.2.0](v1.1.0...v1.2.0) (2024-01-05)

### 🍕 Features

* Add a PR activity chart ([#19](#19)) ([9bac59a](9bac59a))
* spice up contributors pr chart styles ([#20](#20)) ([bdf937f](bdf937f))
* use v2 pr/search ([#16](#16)) ([f1f78ff](f1f78ff))
* Working Nivo chart ([#22](#22)) ([22c07a9](22c07a9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bdougie bdougie bdougie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OgDev-01 @bdougie