Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved accessibility score #358

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+10 −10
Open

Improved accessibility score #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9b1313
fix: fixed changelog Entries that aren't clickable on mobile
dev-phantom Sep 9, 2024
c2950c8
fix: made changelog subtext accessible
dev-phantom Sep 9, 2024
fb52c31
Merge branch 'main' of https://github.com/dev-phantom/landing-page in…
dev-phantom Sep 9, 2024
0f91190
fix: fixed featured post img
dev-phantom Sep 9, 2024
f3e8792
improved accessibity score to 100%
dev-phantom Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/sections/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,11 +138,11 @@ const LocalTypography: FC<LocalTypographyProps> = ({
children,
}) => {
const titleStyle =
'font-bold text-textPrimary opacity-[0.35] text-xs uppercase tracking-[0.2em] pb-8'
'font-bold text-textPrimary opacity-[0.6] text-xs uppercase tracking-[0.2em] pb-8'
const item1Style =
'font-normal text-textPrimary text-sm tracking-[-0.02em] opacity-[0.7] pb-3'
const item2Style =
'font-normal text-textPrimary text-sm tracking-[-0.02em] opacity-[0.35]'
'font-normal text-textPrimary text-sm tracking-[-0.02em] opacity-[0.6]'

const appliedStyle =
variant === 'title'
Expand Down
6 changes: 3 additions & 3 deletions components/sections/blog/FeaturedPost.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ const FeaturedPost: FC<FeaturedPostProps> = ({ data }): ReactElement => {
<div className="w-full largeTablet:grid largeTablet:grid-cols-2 largeTablet:gap-x-11">
<div className="hidden largeTablet:flex">
<GradientBorderWrapper style={{ width: '100%' }}>
<div className="flex-1 h-[496px] relative rounded-[5px] overflow-hidden ">
<Image src={src as string} layout="fill" objectFit="cover" alt="Post cover" />
</div>
<div className="w-full relative rounded-[5px] overflow-hidden ">
<Image width="580" height={304} src={src as string} alt="Cover" />
</div>
</GradientBorderWrapper>
</div>

Expand Down
6 changes: 3 additions & 3 deletions components/sections/blog/components/Post.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ const Post: FC<PostProps> = ({ data, featured }): ReactElement => {
<div className={`${featured && 'largeTablet:hidden'}`}>
<GradientBorderWrapper style={{ width: '100%', borderRadius: '5px' }}>
<div className="w-full relative rounded-[5px] overflow-hidden ">
<Image width="580" height={304} src={src as string} alt="Cover" />
<Image width="580" height={304} className='min-h-[22rem]' src={src as string} alt="Cover" />
</div>
</GradientBorderWrapper>
</div>

<div className="flex justify-start pt-6 pb-2 largeTablet:pt-10">
<div className={`flex justify-start pt-6 pb-2 ${featured ? "largeTablet:pt-4" : "largeTablet:pt-10"} `}>
{topics?.map((item) => (
<div key={item} className="mr-5">
<Typography key={item} variant="body4">{`#${item}`}</Typography>
Expand All @@ -79,7 +79,7 @@ const Post: FC<PostProps> = ({ data, featured }): ReactElement => {
</Link>
</LocalTypography>
</div>
<div className="flex items-center pb-6 largeTablet:pb-10 ">
<div className="flex items-center pb-6 largeTablet:pb-5 ">
<div className="flex-shrink-0 mr-2">
<Image src={OrangeAuthor} alt="Author" />
</div>
Expand Down
4 changes: 2 additions & 2 deletions components/sections/home-page/features/TeamsFeatures.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ function TopUseCase({ topUseCase } : { topUseCase: SanityTeamsPage['topUseCase']
animate={{ opacity: iconInView ? 1 : 0, y: posY, x: iconInView ? 0 : 10 }}
transition={{ duration: 0.7, delay: 0.2, ease: 'easeInOut' }}
>
<img src={image as unknown as string} />
<img src={image as unknown as string} alt="feature-image"/>
</motion.div>
</div>
</div>
Expand Down Expand Up @@ -159,7 +159,7 @@ function TeamFeature({ feature } : { feature : {
animate={{ opacity: iconInView ? 1 : 0, y: posY, x: iconInView ? 0 : 10 }}
transition={{ duration: 0.7, delay: 0.2, ease: 'easeInOut' }}
>
<img src={image as unknown as string} />
<img src={image as unknown as string} alt="feature-image"/>
</motion.div>
</div>
</div>
Expand Down