Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: local config should always take precedence #180

Closed
jpmcb opened this issue Sep 12, 2024 · 0 comments · Fixed by #184
Closed

Bug: local config should always take precedence #180

jpmcb opened this issue Sep 12, 2024 · 0 comments · Fixed by #184
Assignees
@jpmcb
Labels
🐛 bug Something isn't working 👀 needs triage pizza-cli

Comments

@jpmcb
Copy link
Member

jpmcb commented Sep 12, 2024

Describe the bug

Currently, the top level config is always preferred:

❯ ./build/pizza generate codeowners .
Config path loading from -c flag ~/.sauced.yaml

This should be flipped around to where a local .sauced.yaml should be preferred. Then, as a fallback, we should use the ~/.sauced.yaml

Steps to reproduce

  1. Have a ~/.sauced.yaml
  2. Run pizza generate codeowners . in a directory with an existing ~/.sauced.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpmcb jpmcb

Labels
🐛 bug Something isn't working 👀 needs triage pizza-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Config path prefers local dir vs. home dir open-sauced/pizza-cli
1 participant
@jpmcb