Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Config path prefers local dir vs. home dir #184

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: Config path prefers local dir vs. home dir #184

merged 1 commit into from
Sep 12, 2024

Conversation

jpmcb
Copy link
Member

@jpmcb jpmcb commented Sep 12, 2024

Description

Fixes problems where the local config path wasn't being used. Now, it prefers the local path over the one possibly present at home:

❯ ./build/pizza generate codeowners . -l debug
Built logger with log level: 4
Loaded config from: /Users/jpmcb/workspace/opensauced/pizza-cli/.sauced.yaml

Related Tickets & Documents

Closes: #180

Steps to QA

  1. Tests still pass
  2. Build locally with just build and run with a repo that has a .sauced.yaml
  3. Run with a repo that does not have a local .saucedyaml but where you do have a ~/.sauced.yaml

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

@jpmcb jpmcb requested a review from a team September 12, 2024 17:03
nickytonline
nickytonline approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jpmcb jpmcb merged commit 859446a into beta Sep 12, 2024
9 checks passed
@jpmcb jpmcb deleted the config-path-fixes branch September 12, 2024 18:24
open-sauced bot pushed a commit that referenced this pull request Sep 12, 2024
@jpmcb @open-sauced
chore(minor): release 1.5.0-beta.1 on beta channel [skip ci]
74c1e8e 
## [1.5.0-beta.1](v1.4.1-beta.1...v1.5.0-beta.1) (2024-09-12)

### 🍕 Features

* pizza generate insight command ([#179](#179)) ([7315a1d](7315a1d))

### 🐛 Bug Fixes

* Config path prefers local dir vs. home dir ([#184](#184)) ([859446a](859446a))
open-sauced bot pushed a commit that referenced this pull request Sep 16, 2024
@jpmcb @open-sauced
chore(minor): release 1.5.0 [skip ci]
136d138 
## [1.5.0](v1.4.0...v1.5.0) (2024-09-16)

### 🐛 Bug Fixes

* Config path prefers local dir vs. home dir ([#184](#184)) ([859446a](859446a))
* Don't overwrite ldflags in justfile builds ([#171](#171)) ([e024687](e024687))

### 🍕 Features

* Cut 2.0.0 release ([#193](#193)) ([278a833](278a833))
* pizza generate insight command ([#179](#179)) ([7315a1d](7315a1d))
* Update README docs ([#186](#186)) ([99328aa](99328aa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline approved these changes

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: local config should always take precedence
3 participants
@jpmcb @brandonroberts @nickytonline