-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically generate .sauced.yaml
file
#137
Conversation
…feat/generate-config-yaml
PSA: you'll want to rebase on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Just a few small nits and this is ready to go! Seriously, huge lift. Great work 🐹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having an existing .sauced.yaml, it regenerated it, but the missing premable in comments got removed. Not sure if that's from our template, but just mentioning it.
When regenerating the .sauced.yaml, if one is detected (non-interactive mode) potentially mention it before they proceed.
Also, not sure how far back we're looking by default in the git history, but I see Anush, one of our interns in the list.
Also, we should skip known bot accounts, i.e. any account ending in [bot]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working really great @zeucapua! Small change request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
These can be in a future PR:
Should I make issues? |
Yes, I was going to say: let's followup any additional feedback / bugs in new issues and PRs |
Description
Two modes of generating:
Automatic
Interactive
Ctrl+I
Related Tickets & Documents
Closes #97
Mobile & Desktop Screenshots/Recordings
Steps to QA
just build
./build/pizza generate config
-o
/--output-path
flag to set a directory-i
/--interactive
flag to attribute each email manuallyTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?