fix: skip interactive steps in generate codeowners with --tty-disable flag #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
force-pushed
the
nickytonline/tty-disable
branch
from
78306af to
ce31d3f
Compare
jpmcb
approved these changes
Sep 6, 2024
brandonroberts
approved these changes
Sep 6, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
## [1.3.1-beta.1](v1.3.0...v1.3.1-beta.1) (2024-09-06) ### 🐛 Bug Fixes * skip interactive steps in generate codeowners with --tty-disable flag ([#159](#159)) ([49f1fd3](49f1fd3))
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
## [1.4.0](v1.3.0...v1.4.0) (2024-09-11) ### 🍕 Features * Posthog events bootstrapping ([#160](#160)) ([847426b](847426b)) ### 🐛 Bug Fixes * docs generation runs outside of build matrix now ([#165](#165)) ([1e42988](1e42988)) * fixed docs generation in release workflow ([#162](#162)) ([5341e16](5341e16)) * now --tty-disable is set so the action can complete instead of hanging ([#164](#164)) ([a970a73](a970a73)) * skip interactive steps in generate codeowners with --tty-disable flag ([#159](#159)) ([49f1fd3](49f1fd3)) * use the local directory and home directory as fallback for .sauced.yaml ([#158](#158)) ([af2f361](af2f361))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now if the
--tty-disableflag is passed to generate a codeowners, the interactive steps are skipped.There are currently no tests for codeowners.go. I'm going to look at adding some.(punting for now as mentioned below)Related Tickets & Documents
Closes #154
Mobile & Desktop Screenshots/Recordings
Steps to QA
just build./build/pizza generate codeowners --tty-disable./build/pizza generate codeownersTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?