-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs generation runs outside of build matrix now #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
commented
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense @open-sauced/engineering, It's a little more difficult to test all this on a test repo. I could probably fork and remove some of what semantic release and the build do to test this out.
nickytonline
force-pushed
the
nickytonline/3rd-times-a-charm
branch
from
September 9, 2024 18:02
7320824
to
abfad0f
Compare
Co-authored-by: Brandon Roberts <[email protected]>
brandonroberts
approved these changes
Sep 9, 2024
nickytonline
commented
Sep 9, 2024
jpmcb
reviewed
Sep 9, 2024
jpmcb
approved these changes
Sep 9, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
## [1.4.0-beta.4](v1.4.0-beta.3...v1.4.0-beta.4) (2024-09-09) ### 🐛 Bug Fixes * docs generation runs outside of build matrix now ([#165](#165)) ([1e42988](1e42988))
open-sauced bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
## [1.4.0](v1.3.0...v1.4.0) (2024-09-11) ### 🍕 Features * Posthog events bootstrapping ([#160](#160)) ([847426b](847426b)) ### 🐛 Bug Fixes * docs generation runs outside of build matrix now ([#165](#165)) ([1e42988](1e42988)) * fixed docs generation in release workflow ([#162](#162)) ([5341e16](5341e16)) * now --tty-disable is set so the action can complete instead of hanging ([#164](#164)) ([a970a73](a970a73)) * skip interactive steps in generate codeowners with --tty-disable flag ([#159](#159)) ([49f1fd3](49f1fd3)) * use the local directory and home directory as fallback for .sauced.yaml ([#158](#158)) ([af2f361](af2f361))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This continues in the work in #162, however, now the docs is a separate job so it doesn't repeat itself in the build matrix job.
Related Tickets & Documents
Fixes #161
Mobile & Desktop Screenshots/Recordings
Steps to QA
We can try on beta again. This is a little more difficult to test on a test repo.
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?