Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs generation runs outside of build matrix now #165

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Sep 9, 2024

Description

This continues in the work in #162, however, now the docs is a separate job so it doesn't repeat itself in the build matrix job.

Related Tickets & Documents

Fixes #161

Mobile & Desktop Screenshots/Recordings

Steps to QA

We can try on beta again. This is a little more difficult to test on a test repo.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Member Author

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense @open-sauced/engineering, It's a little more difficult to test all this on a test repo. I could probably fork and remove some of what semantic release and the build do to test this out.

@nickytonline nickytonline marked this pull request as ready for review September 9, 2024 17:55
@nickytonline nickytonline requested a review from a team September 9, 2024 17:55
@nickytonline nickytonline force-pushed the nickytonline/3rd-times-a-charm branch from 7320824 to abfad0f Compare September 9, 2024 18:02
Co-authored-by: Brandon Roberts <[email protected]>
@nickytonline nickytonline requested a review from a team September 9, 2024 19:00
@jpmcb jpmcb merged commit 1e42988 into beta Sep 9, 2024
9 checks passed
@jpmcb jpmcb deleted the nickytonline/3rd-times-a-charm branch September 9, 2024 22:28
open-sauced bot pushed a commit that referenced this pull request Sep 9, 2024
## [1.4.0-beta.4](v1.4.0-beta.3...v1.4.0-beta.4) (2024-09-09)

### 🐛 Bug Fixes

* docs generation runs outside of build matrix now ([#165](#165)) ([1e42988](1e42988))
open-sauced bot pushed a commit that referenced this pull request Sep 11, 2024
## [1.4.0](v1.3.0...v1.4.0) (2024-09-11)

### 🍕 Features

* Posthog events bootstrapping ([#160](#160)) ([847426b](847426b))

### 🐛 Bug Fixes

* docs generation runs outside of build matrix now ([#165](#165)) ([1e42988](1e42988))
* fixed docs generation in release workflow ([#162](#162)) ([5341e16](5341e16))
* now --tty-disable is set so the action can complete instead of hanging ([#164](#164)) ([a970a73](a970a73))
* skip interactive steps in generate codeowners with --tty-disable flag ([#159](#159)) ([49f1fd3](49f1fd3))
* use the local directory and home directory as fallback for .sauced.yaml ([#158](#158)) ([af2f361](af2f361))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: release action - docs git push fails
3 participants