Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shortcut to skip rest of emails for pizza generate config #197

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat: shortcut to skip rest of emails for pizza generate config #197

merged 3 commits into from
Sep 18, 2024

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented Sep 18, 2024 •
edited
Loading

Description

Implements a new 'skip rest of emails' shortcut using Ctrl+S for the pizza generate config command in interactive mode.

Related Tickets & Documents

Closes #177

Mobile & Desktop Screenshots/Recordings

Built-in.Retina.Display.mp4

Steps to QA

  1. Build the program
  2. Run pizza generate config with the -i/--interactive flag
  3. Go through a few attributions
  4. Press Ctrl+S to skip the rest of the emails and end the program
  5. Check the output .sauced.yaml file and see only a few you've attributed in the file

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@zeucapua zeucapua requested a review from a team September 18, 2024 15:59
nickytonline
nickytonline reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well but the TUI shows ctrl + i for ignoring email and skipping the rest as well. Should it not show the ctrl + s as well?

CleanShot 2024-09-18 at 12 53 12

jpmcb
jpmcb reviewed Sep 18, 2024
View reviewed changes
cmd/generate/config/spec.go Outdated Show resolved Hide resolved
nickytonline
nickytonline approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jpmcb jpmcb merged commit 6e96fff into beta Sep 18, 2024
9 checks passed
@jpmcb jpmcb deleted the feat/generate-config-skip-rest branch September 18, 2024 17:37
open-sauced bot pushed a commit that referenced this pull request Sep 18, 2024
@zeucapua @open-sauced
chore(minor): release 2.2.0-beta.2 on beta channel [skip ci]
19ed450 
## [2.2.0-beta.2](v2.2.0-beta.1...v2.2.0-beta.2) (2024-09-18)

### 🍕 Features

* shortcut to skip rest of emails for `pizza generate config` ([#197](#197)) ([6e96fff](6e96fff))
open-sauced bot pushed a commit that referenced this pull request Sep 18, 2024
@jpmcb @open-sauced
chore(minor): release 2.2.0 [skip ci]
e99679b 
## [2.2.0](v2.1.0...v2.2.0) (2024-09-18)

### 🍕 Features

* shortcut to skip rest of emails for `pizza generate config` ([#197](#197)) ([6e96fff](6e96fff))
* Upgrades to v2 packages to track with v2 git tag ([#198](#198)) ([5a0995d](5a0995d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

@nickytonline nickytonline nickytonline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: skip rest of attribution during config generation
3 participants
@zeucapua @nickytonline @jpmcb