Skip to content

update cse-cli, cmd & help response to v 0.2.0 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2020
Merged

Conversation

yingguangchu
Copy link
Contributor

open issue #12

Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the other comments, I noticed that the cse inspect documentation is not up to date. (For some reason I couldn't put a comment on that line.) You should probably go through all commands and re-check the output.

cse-cli.md Outdated
It can simulate single FMUs and show the model descriptions. Besides being a necessary simulation tool, the CSE command line interface also serves as a demonstration for how client applications can make use of the CSE co-simulation library.
With the command-line interface, the co-simulation library is used to enable co-simulation from the command-line.

This page collects design ideas for the CSE command-line interface (CLI).

### Functionality and design
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole section should be removed or rewritten. The Confluence page it's taken from was just intended as a "design ideas" document, not as formal documentation, and this section really shows it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you review this page and update if any more information?
I'm not sure it's necessary to have all the help codes exposed in this page. Perhaps only the help to show the commands.

Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that you've included the help command in some cases but not in others. You may want to fix that. For example, you've included the line

> cse help run-single

before the help text for cse run-single, but you have not done the same for cse run.

There are also some commands like plain cse which just produces an error message, and cse --version, which don't seem necessary in a page like this. (Again, they were included in the document I wrote because it was a design spec, not documentation.)

None of the above are a big deal, though, and otherwise, I think this page looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants