Move removeIndex's result instead of copying (#1516)

Currently removeIndex copies the removed value into removed and then destructs the original, which can cause significant performance overhead. Co-authored-by: Jordan Bayles <[email protected]>
open-source-parsers · Sep 10, 2024 · fdb529b · fdb529b
1 parent 8d1ea70
commit fdb529b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -1205,7 +1205,7 @@ bool Value::removeIndex(ArrayIndex index, Value* removed) {
     return false;
   }
   if (removed)
-    *removed = it->second;
+    *removed = std::move(it->second);
   ArrayIndex oldSize = size();
   // shift left all items left, into the place of the "removed"
   for (ArrayIndex i = index; i < (oldSize - 1); ++i) {