Fix/keep consistent with fsrs-optimizer (#246)

* set eps of adam to 1e-8

* set seed to 2023

* filter and sort train_set when benchmark

* locate the bug related to parameter_clipper

* fix parameter_clipper

* update to burn v0.13.2

* bump version

* make max_seq_len configurable & sort by length

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "fsrs"
-version = "1.4.0"
+version = "1.4.1"
 authors = ["Open Spaced Repetition"]
 categories = ["algorithms", "science"]
 edition = "2021"
@@ -15,15 +15,15 @@ description = "FSRS for Rust, including Optimizer and Scheduler"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies.burn]
-version = "0.13.1"
+version = "0.13.2"
 # git = "https://github.com/tracel-ai/burn.git"
 # rev = "6ae3926006872a204869e84ffc303417c54b6b7f"
 # path = "../burn/burn"
 default-features = false
 features = ["std", "train", "ndarray"]
 
 [dev-dependencies.burn]
-version = "0.13.1"
+version = "0.13.2"
 # git = "https://github.com/tracel-ai/burn.git"
 # rev = "6ae3926006872a204869e84ffc303417c54b6b7f"
 # path = "../burn/burn"

src/parameter_clipper.rs

@@ -2,13 +2,23 @@ use crate::{
     inference::{Parameters, S_MIN},
     pre_training::INIT_S_MAX,
 };
-use burn::tensor::{backend::Backend, Data, Tensor};
+use burn::{
+    module::Param,
+    tensor::{backend::Backend, Data, Tensor},
+};
 
-pub(crate) fn parameter_clipper<B: Backend>(parameters: Tensor<B, 1>) -> Tensor<B, 1> {
-    let val = clip_parameters(&parameters.to_data().convert().value);
-    Tensor::from_data(
-        Data::new(val, parameters.shape()).convert(),
-        &B::Device::default(),
+pub(crate) fn parameter_clipper<B: Backend>(
+    parameters: Param<Tensor<B, 1>>,
+) -> Param<Tensor<B, 1>> {
+    let (id, val) = parameters.consume();
+    let clipped = clip_parameters(&val.to_data().convert().value);
+    Param::initialized(
+        id,
+        Tensor::from_data(
+            Data::new(clipped, val.shape()).convert(),
+            &B::Device::default(),
+        )
+        .require_grad(),
     )
 }
 
@@ -58,7 +68,7 @@ mod tests {
             &device,
         );
 
-        let param: Tensor<1> = parameter_clipper(tensor);
+        let param = parameter_clipper(Param::from_tensor(tensor));
         let values = &param.to_data().value;
 
         assert_eq!(