-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add commander stopping sync mechanism #352
Merged
tigrannajaryan
merged 5 commits into
open-telemetry:main
from
rogercoll:fix_example_race
Feb 20, 2025
Merged
fix: add commander stopping sync mechanism #352
tigrannajaryan
merged 5 commits into
open-telemetry:main
from
rogercoll:fix_example_race
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 78.29% 78.29%
=======================================
Files 25 25
Lines 2386 2386
=======================================
Hits 1868 1868
Misses 410 410
Partials 108 108 ☔ View full report in Codecov by Sentry. |
tigrannajaryan
previously requested changes
Feb 19, 2025
Co-authored-by: Tigran Najaryan <[email protected]>
tigrannajaryan
approved these changes
Feb 20, 2025
Thanks for the fix @rogercoll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #256
Test that generates the data race:
It looks like the commander struct is started in a go routine when the
NewSupervisor
is created. The data race happens when the commander is stopped (supervisor.Shutdown()
) while being initalized (Start).The fix adds a synchronization mechanism to prevent the commander being started if it is already being stopped.