Add ability to throttle exports when reading from disk. #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idth usage when exporting spans, allowing for smoother data flow and preventing resource hogging. It can further refine the size estimation logic based on a specific use case.
…idth usage when exporting spans, allowing for smoother data flow and preventing resource hogging. It can further refine the size estimation logic based on a specific use case. Relate to Add ability to throttle exports when reading from disk. open-telemetry#638
marandaneto
reviewed
Oct 28, 2024
core/src/main/java/io/opentelemetry/android/export/RateLimitedExporter.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Oct 28, 2024
core/src/main/java/io/opentelemetry/android/export/RateLimitedExporter.java
Outdated
Show resolved
Hide resolved
Relate to open-telemetry#638
marandaneto
reviewed
Oct 30, 2024
…nterface and Duration with a plain long value for timeWindowInMillis ref open-telemetry#638
breedx-splk
reviewed
Nov 1, 2024
breedx-splk
reviewed
Nov 1, 2024
core/src/main/java/io/opentelemetry/android/export/RateLimitedExporter.java
Show resolved
Hide resolved
Ref: Add ability to throttle exports when reading from disk. open-telemetry#638
marandaneto
reviewed
Nov 12, 2024
core/src/main/java/io/opentelemetry/android/export/RateLimitedExporter.java
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Nov 12, 2024
Comment on lines
89
to
92
| final SpanExporter delegate; | ||
| CategoryFunction categoryFunction = span -> "default"; | ||
| long maxBytesPerSecond = 1024; // Default to 1 KB/s | ||
| long timeWindowInMillis = 1000; // Default to 1 second |
There was a problem hiding this comment.
should they be private since they have a setter anyway (using the builder pattern)?
There was a problem hiding this comment.
Since the fields are intended to be set only through the builder methods i have tried to add and make them private so they can only be modified through it's provided builder methods. I'm sure it will help enhance encapsulation and help maintain the integrity of it's object's state.
There was a problem hiding this comment.
delegate can also be private I guess
There was a problem hiding this comment.
Relate to open-telemetry#638
Relate to open-telemetry#638
|
@Victorsesan are you able to come back to this any time soon? Thanks! |
breedx-splk
added
the
needs author feedback
|
Hey @breedx-splk Yes i will, i think i lastly made a change that needed a mod review. Still waiting |
github-actions
bot
removed
the
needs author feedback
marandaneto
reviewed
Feb 4, 2025
| } | ||
|
|
||
| static class Builder { | ||
| final SpanExporter delegate; |
There was a problem hiding this comment.
Suggested change
| final SpanExporter delegate; | |
| private final SpanExporter delegate; |
|
#663 (comment) left and ready to go, I will approve meanwhile. |
marandaneto
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an implementation which provides a flexible way to manage bandwidth usage when exporting spans, allowing for smoother data flow and preventing resource hogging. It can further refine the size estimation logic based on a specific use case.
Relate to #638