fix: Use a default cut string of ' ' when replacement is empty

open-telemetry · Dec 19, 2024 · 695e800 · 695e800
1 parent 5167e4c
commit 695e800
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/ottl/ottlfuncs/func_trim.go b/pkg/ottl/ottlfuncs/func_trim.go
@@ -37,6 +37,9 @@ func trim[K any](target ottl.StringGetter[K], replacement ottl.Optional[string])
 		if err != nil {
 			return nil, err
 		}
+		if replacement.IsEmpty() {
+			return strings.Trim(val, " "), nil
+		}
 		return strings.Trim(val, replacementString), nil
 	}
 }
diff --git a/pkg/ottl/ottlfuncs/func_trim_test.go b/pkg/ottl/ottlfuncs/func_trim_test.go
@@ -50,7 +50,7 @@ func Test_trim(t *testing.T) {
 				},
 			},
 			replacement: ottl.Optional[string]{},
-			expected:    " this is a test ",
+			expected:    "this is a test",
 			shouldError: false,
 		},
 		{