Skip to content

Commit

Permalink
(internal/otelarrow) Remove time-based test in e2e tests (#36034)
Browse files Browse the repository at this point in the history
#### Description

Remove a flaky portion of the internal/otelarrow/test e2e test.
#### Link to tracking issue
Fixes #34719.

#### Testing

There was a time-based test that has proven unreliable.

#### Documentation

n/a
  • Loading branch information
jmacd authored Oct 29, 2024
1 parent e8256ae commit ef14e6e
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions internal/otelarrow/test/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,6 @@ func (tc *testConsumer) ConsumeTraces(ctx context.Context, td ptrace.Traces) err
timeout := time.Until(dead)

require.Equal(tc.t, tc.expectDeadline, hasDeadline, "deadline set or not set: %v", timeout)
if tc.expectDeadline {
// expect allows 1/6 of the deadline to elapse in transit,
// so 1m becomes 50s.
expect := tc.expCfg.TimeoutSettings.Timeout * 5 / 6
require.Less(tc.t, expect, timeout)
require.Greater(tc.t, tc.expCfg.TimeoutSettings.Timeout, timeout)
}

return tc.sink.ConsumeTraces(ctx, td)
}
Expand Down

0 comments on commit ef14e6e

Please sign in to comment.