-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/opamp]: Add mechanism to detect whether the collector has been orphaned #32564
Merged
evan-bradley
merged 18 commits into
open-telemetry:main
from
observIQ:feat/opamp-extension-monitor-ppid
May 3, 2024
Merged
[extension/opamp]: Add mechanism to detect whether the collector has been orphaned #32564
evan-bradley
merged 18 commits into
open-telemetry:main
from
observIQ:feat/opamp-extension-monitor-ppid
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
evan-bradley,
portertech and
tigrannajaryan
April 19, 2024 17:33
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
from
April 22, 2024 17:06
9c7ac76
to
42b03db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I forgot to publish my review. Mostly looks good to me, just a few comments. I'll take another look through it shortly.
evan-bradley
approved these changes
Apr 29, 2024
srikanthccv
reviewed
May 1, 2024
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
2 times, most recently
from
May 3, 2024 19:10
287fc82
to
f09e1f4
Compare
BinaryFissionGames
force-pushed
the
feat/opamp-extension-monitor-ppid
branch
from
May 3, 2024 21:15
20978e6
to
51ec112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/otelcontribcol
otelcontribcol command
extension/opamp
Run Windows
Enable running windows test on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: This is part of #32189 - It does not resolve this issue because the supervisor still needs changes to pass the its PID in.
Testing:
Added some unit tests.
I've manually tested it on my macbook with this PR: observIQ#4715
(running supervisor, kill -9 the supervisor, and take a look at the agent logs to see it shut down).
I've tried testing this out on Windows, but the supervisor doesn't get past bootstrapping (the Commander's Stop function does not work on windows), so I wasn't able to fully test it.
Documentation:
Added new parameter to README