sumologicexporter: do not replace . with _ for prometheus format
#32595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Rosiek <[email protected]>
github-actions
bot
requested review from
aboguszewski-sumo,
kasia-kujawa,
mat-rumian,
rnishtala-sumo and
swiatekm
Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
commented
Apr 22, 2024
swiatekm
approved these changes
Apr 22, 2024
|
Failing unit test is frequency of #32391, I've added a reference there. |
mx-psi
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use new formatter for prometheus, which fixes metric name sanitization. This also refactors the formatter itself, which is part of #31479 and reduces size of #32315
Link to tracking Issue:
Applies SumoLogic/sumologic-otel-collector#211 and more, but this one is a bug fix
Testing:
Unit tests
Documentation:
N/A