Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsemf] Put metrics fields to bottom of EMF log entry #33002

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented May 11, 2024

Description:

Cherry-picking from downstream: amazon-contributing#108

This is a short-term solution to workaround CW log insight limitation by placing metrics fields to the bottom of log entry.

Link to tracking Issue:
#26697

Testing:
Passed unit test.

Documentation:

@jj22ee jj22ee requested a review from a team May 11, 2024 05:19
@github-actions github-actions bot added the exporter/awsemf awsemf exporter label May 11, 2024
@jj22ee jj22ee marked this pull request as draft May 14, 2024 21:00
@jj22ee jj22ee marked this pull request as ready for review May 16, 2024 17:31
Copy link
Contributor

@vastin vastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. ty.

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. See here for more on why depending on the order of fields in a JSON object is a bad idea.

@jj22ee jj22ee closed this May 23, 2024
@mxiamxia
Copy link
Member

The original issue will be fixed by CloudWatch backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/awsemf awsemf exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants