[influxdb] remove uint fields from InfluxDB plugins #33228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#29896 This change removes the Metric signal `flags` field to/from InfluxDB conversion. The InfluxDB field is type `uint` which is not supported in InfluxDB v1 AND the Metric `flags` field is not particularly useful (yet) in OpenTelemetry.
jacobmarble
force-pushed
the
influxdbv1-flags
branch
from
a6a51ad to
e579400
Compare
github-actions
bot
added
cmd/configschema
mx-psi
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change removes the Metric signal
flagsfield to/from InfluxDB conversion. The InfluxDB field is typeuintwhich is not supported in InfluxDB v1 AND the Metricflagsfield is not particularly useful (yet) in OpenTelemetry.Link to tracking Issue:
Fixes #29896
Testing:
Material code changes and tests in influxdata/influxdb-observability#305
Documentation:
Small changes to docs in influxdata/influxdb-observability#305