Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsemf] Update ApplicationSignals log group name and adjust AWS service name #33798

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Jun 27, 2024

Description:

Cherry-picking from downstream: amazon-contributing#197

Changes:

  • unify the log group name to /aws/application-signals/data.
  • rename Application Signals metric namespace.
  • removed OTelLib name label from EMF log

Link to tracking Issue:

Testing:

Documentation:

@jj22ee jj22ee marked this pull request as ready for review June 27, 2024 22:03
@jj22ee jj22ee requested a review from Aneurysm9 as a code owner June 27, 2024 22:03
@jj22ee jj22ee requested a review from a team June 27, 2024 22:03
@jj22ee jj22ee requested a review from bryan-aguilar as a code owner June 27, 2024 22:03
@bjrara
Copy link
Contributor

bjrara commented Jun 28, 2024

One visible change to the existing behavior is that we removed OTelLib from EMF log.

exporter/awsemfexporter/datapoint.go Outdated Show resolved Hide resolved
@jj22ee jj22ee requested a review from Aneurysm9 June 28, 2024 23:43
@jj22ee
Copy link
Contributor Author

jj22ee commented Jul 3, 2024

Hi @dmitryax, sorry to ping you for this PR that wasn't assigned to you. @bryan-aguilar isn't active in OpenTelemetry, I suppose we may need to move him to emeritus status. Could you help again to approve/merge this PR in his place?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@jj22ee
Copy link
Contributor Author

jj22ee commented Jul 31, 2024

Hi, any update on this PR, can it be merged?

@jj22ee
Copy link
Contributor Author

jj22ee commented Jul 31, 2024

pinging @atoulme @dmitryax

@atoulme
Copy link
Contributor

atoulme commented Jul 31, 2024

I am not the right person to review this PR since it's specific to AWS but I see @Aneurysm9 reviewed and approved, so I guess this is good to go.

@github-actions github-actions bot removed the Stale label Jul 31, 2024
@dmitryax dmitryax merged commit 23013d3 into open-telemetry:main Aug 1, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants