Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelarrowreceiver] Avoid one unnecessary span error at stream EOF #34175

Merged
merged 11 commits into from
Jul 22, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jul 19, 2024

Description: We have been using the OTel-Arrow components in production and begun to monitor the component's health using span data. There are spans coming from otelgrpc instrumentation and there are explicit spans in both components.

This adds a new test that exercises multiple streams between the exporter and receiver components. At the end of the test, it checks for no span errors, with one exception discussed in open-telemetry/opentelemetry-go-contrib#2644. We will not modify the logic of these components to avoid stream cancelation, we will lobby for stream cancelation not to register as span errors.

The receiver is modified to avoid setting Span errors for EOF and Cancelation following its existing logic for setting log severity for the same condition. As a result, the otel_arrow_stream_inflight span will not show errors for the final Recv() as a stream shuts down.

Link to tracking Issue: Part of open-telemetry/otel-arrow#227.

Testing: A new test is added.

.chloggen/otelarrow-spanerrors.yaml Outdated Show resolved Hide resolved
receiver/otelarrowreceiver/internal/arrow/arrow.go Outdated Show resolved Hide resolved
receiver/otelarrowreceiver/internal/arrow/arrow.go Outdated Show resolved Hide resolved
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jul 19, 2024
@codeboten codeboten merged commit 8f6e9c6 into open-telemetry:main Jul 22, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/otelarrow ready to merge Code review completed; ready to merge by maintainers receiver/otelarrow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants