-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelarrowreceiver] Avoid one unnecessary span error at stream EOF #34175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
reviewed
Jul 19, 2024
mwear
approved these changes
Jul 19, 2024
moh-osman3
approved these changes
Jul 19, 2024
crobert-1
approved these changes
Jul 19, 2024
crobert-1
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Jul 19, 2024
codeboten
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
internal/otelarrow
ready to merge
Code review completed; ready to merge by maintainers
receiver/otelarrow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We have been using the OTel-Arrow components in production and begun to monitor the component's health using span data. There are spans coming from otelgrpc instrumentation and there are explicit spans in both components.
This adds a new test that exercises multiple streams between the exporter and receiver components. At the end of the test, it checks for no span errors, with one exception discussed in open-telemetry/opentelemetry-go-contrib#2644. We will not modify the logic of these components to avoid stream cancelation, we will lobby for stream cancelation not to register as span errors.
The receiver is modified to avoid setting Span errors for EOF and Cancelation following its existing logic for setting log severity for the same condition. As a result, the
otel_arrow_stream_inflight
span will not show errors for the finalRecv()
as a stream shuts down.Link to tracking Issue: Part of open-telemetry/otel-arrow#227.
Testing: A new test is added.