[receiver/prometheus]: Group scraped metrics into resources created from job/instance label pairs
#34344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
…and add tests Signed-off-by: Florian Bacher <[email protected]>
…nd resources detected during scrape Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
dashpole
reviewed
Aug 2, 2024
Signed-off-by: Florian Bacher <[email protected]>
dashpole
approved these changes
Aug 6, 2024
# Conflicts: # receiver/prometheusreceiver/internal/transaction.go
evan-bradley
approved these changes
Aug 26, 2024
Co-authored-by: Evan Bradley <[email protected]>
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…rom `job`/`instance` label pairs (open-telemetry#34344) **Description:** This PR solves a bug where metrics with different `job`/`instance` labels were added into the same resource. This can happen with the `honor_labels` being set to `true`, in which case those labels are not taken by the scrape config, but from the individual data points that are aggregated during a scrape iteration. This change also affects the use of relabel configs, if the job or instance labels of gathered metrics are changed by those. Here a new resource for each distinct job/instance label will be created, with the matching metrics being added to those. The additional scrape metrics (number of scraped samples, scrape duration, up, etc.) will be put into a resource representing the scrape config. **Link to tracking Issue:** open-telemetry#34237 **Testing:** Added Unit tests and adapted relevant e2e tests --------- Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR solves a bug where metrics with different
job/instancelabels were added into the same resource. This can happen with thehonor_labelsbeing set totrue, in which case those labels are not taken by the scrape config, but from the individual data points that are aggregated during a scrape iteration.This change also affects the use of relabel configs, if the job or instance labels of gathered metrics are changed by those. Here a new resource for each distinct job/instance label will be created, with the matching metrics being added to those. The additional scrape metrics (number of scraped samples, scrape duration, up, etc.) will be put into a resource representing the scrape config.
Link to tracking Issue: #34237
Testing: Added Unit tests and adapted relevant e2e tests