[exporter/syslog] Fix issue where exporter may hang indefinitely while dialing #34393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
syslog-exporter-context
branch
from
20f6a3f to
2822bf3
Compare
github-actions
bot
requested review from
andrzej-stencel,
kasia-kujawa and
rnishtala-sumo
crobert-1
approved these changes
Aug 2, 2024
mwear
approved these changes
Aug 6, 2024
kasia-kujawa
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a report of a collector not shutting down properly. Regardless of the underlying cause, it seems that the dialer was not being passed a context, so did not cancel the attempt to dial in a reasonable timeframe. This PR just passes context through to the dialer.