[receiver/k8scluster] quiet warning down to info #34817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
quiet_k8scluster_warnings
branch
from
d6e2aa8 to
aa56594
Compare
dmitryax
approved these changes
Aug 22, 2024
| func logWarning(ref *v1.OwnerReference, podUID types.UID, logger *zap.Logger) { | ||
| logger.Warn( | ||
| func logInfo(ref *v1.OwnerReference, podUID types.UID, logger *zap.Logger) { | ||
| logger.Info( |
There was a problem hiding this comment.
I'd suggest using debug here. Otherwise LGTM
atoulme
force-pushed
the
quiet_k8scluster_warnings
branch
from
aa56594 to
e6b7bdf
Compare
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** We log a warning on cache miss in the k8sclusterreceiver pod watcher. This PR moves this log from a warning to an info log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We log a warning on cache miss in the k8sclusterreceiver pod watcher.
This PR moves this log from a warning to an info log.