[exporter/opensearch] chore: remove redundant config Validate call #35233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skip changelog |
jpkrohling
changed the title
jpkrohling
requested review from
Aneurysm9
and removed request for
jpkrohling
|
Not sure I was added as reviewer, the code owners for this are: @Aneurysm9 @MitchellGale @MaxKsyunz @YANG-DB |
|
@rogercoll thanks for your contribution |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
YANG-DB
approved these changes
Oct 11, 2024
|
@rogercoll |
VihasMakwana
approved these changes
Oct 16, 2024
MovieStoreGuy
approved these changes
Oct 18, 2024
MovieStoreGuy
added
the
Skip Changelog
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…pen-telemetry#35233) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Configuration validation is done during collector's startup, making it redundant when being called inside component's logic. This PR removes the Validate call done during exporter's constructor. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#33498 (Last component, will close the issue) **Testing:** <Describe what testing was performed and which tests were added.> Added default config use case (validate error) **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Configuration validation is done during collector's startup, making it redundant when being called inside component's logic. This PR removes the Validate call done during exporter's constructor.
Link to tracking Issue: #33498 (Last component, will close the issue)
Testing: Added default config use case (validate error)
Documentation: