[exporter/splunkhecexporter] Add OtelAttrsToHec struct and related config fields
#35476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Sep 27, 2024
exporter/splunkhecexporter/README.md
Outdated
| - `hec_metadata_to_otel_attrs/source` (default = 'com.splunk.source'): Specifies the mapping of a specific unified model attribute value to the standard source field of a HEC event. | ||
| **Deprecated** (v0.109.0): prefer `otel_attrs_to_hec_metadata/source`. |
There was a problem hiding this comment.
Suggested change
| **Deprecated** (v0.109.0): prefer `otel_attrs_to_hec_metadata/source`. | |
| **Deprecated** (v0.111.0): prefer `otel_attrs_to_hec_metadata/source`. |
atoulme
reviewed
Sep 27, 2024
atoulme
reviewed
Sep 27, 2024
atoulme
reviewed
Sep 27, 2024
|
@atoulme, any further issues or is this ready to merge? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
atoulme
approved these changes
Oct 25, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
I would still like to see this PR merge. Is there some step that I am overlooking on how to get this to be merged? |
|
@atoulme, is there some way to revive this PR or do I need to create another one? |
atoulme
reviewed
Dec 7, 2024
|
Changes still look good to me. You need to update the README for the deprecation notice. |
This new struct is used when converting an OTel log message into a Splunk message. Any fields that are modified in the HecToOtelAttrs struct will be used in this new struct unless the corresponding field has already been modified there.
atoulme
approved these changes
Dec 10, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…config fields (open-telemetry#35476) **Description:** Adding a new config fields `otel_attrs_to_hec_metadata/*` to replace the `hec_metadata_to_otel_attrs/*` config fields. **Link to tracking Issue:** fixes open-telemetry#35092 **Testing:** No new tests added, modified existing tests. **Documentation:** Adding field-level description to exporter README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adding a new config fields
otel_attrs_to_hec_metadata/*to replace thehec_metadata_to_otel_attrs/*config fields.Link to tracking Issue: fixes #35092
Testing: No new tests added, modified existing tests.
Documentation: Adding field-level description to exporter README.md.