(otelarrowexporter) Adjust configuration based on experimental results #35478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
exporter/otelarrow
internal/otelarrow
receiver/otelarrow
labels
jmacd
force-pushed
the
jmacd/new_defaults
branch
from
09ff868 to
1db1808
Compare
jmacd
changed the title
mwear
approved these changes
Oct 2, 2024
| @@ -59,15 +57,14 @@ func createDefaultConfig() component.Config { | |||
| BalancerName: "round_robin", | |||
| }, | |||
| Arrow: ArrowConfig{ | |||
| NumStreams: runtime.NumCPU(), | |||
| MaxStreamLifetime: time.Hour, | |||
| NumStreams: arrow.DefaultNumStreams, | |||
There was a problem hiding this comment.
Not this PR problem. But arrow confused me where it comes from, the fact that is an internal value.
sfc-gh-bdrutu
approved these changes
Oct 4, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
open-telemetry#35478) **Description:** As reported in https://opentelemetry.io/blog/2024/otel-arrow-production/, we have run a number of experiments with the OTel-Arrow components. Our preferred configuration after these experiments is as-seen in this PR. **Link to tracking Issue:** open-telemetry#26491 **Testing:** As in https://opentelemetry.io/blog/2024/otel-arrow-production. **Documentation:** Included.
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
open-telemetry#35478) **Description:** As reported in https://opentelemetry.io/blog/2024/otel-arrow-production/, we have run a number of experiments with the OTel-Arrow components. Our preferred configuration after these experiments is as-seen in this PR. **Link to tracking Issue:** open-telemetry#26491 **Testing:** As in https://opentelemetry.io/blog/2024/otel-arrow-production. **Documentation:** Included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: As reported in https://opentelemetry.io/blog/2024/otel-arrow-production/, we have run a number of experiments with the OTel-Arrow components. Our preferred configuration after these experiments is as-seen in this PR.
Link to tracking Issue: #26491
Testing: As in https://opentelemetry.io/blog/2024/otel-arrow-production.
Documentation: Included.