[receiver/podman] Fix precision for cpu metrics #35633
Open
+63
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosuke
force-pushed
the
podman-cpu-precision
branch
from
21ebab3 to
0af750b
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Any updates? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@open-telemetry/collector-contrib-approvers any feedback on this PR? Thanks! |
andrzej-stencel
approved these changes
Dec 11, 2024
ChrsMark
approved these changes
Dec 11, 2024
TylerHelmuth
approved these changes
Dec 16, 2024
TylerHelmuth
added
the
ready to merge
|
Needs the latest from main |
TylerHelmuth
removed
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Podman provides cpu time metrics with nanosecond precision, but the current implementation truncates this to an integer with second precision, which loses a lot of information, so I made it a floating point number to preserve precision.
Testing
Use
assert.InDeltafor tests with floating point numbers.