feat: prom translation rw2 add support for labels

[jmichalek132]

Description

Adding full support for handling labels.

Link to tracking issue #33661

Fixes

Testing

Documentation

[ArthurSens]

It would be awesome if we could avoid copy-pasting code, and I think it is avoidable here.

Duplicated code increases cognitive load as we need to read 200 lines of code just to understand they do exactly the same thing. Duplicated code doesn't age well as we're all flawed humans with terrible memory and eventually make a change in one place and do not on in the other.

I know this would involve quite some work because we're relying on labels built-in functions for sorting and stuff, but could we refactor it to avoid duplicated code?

[aknuds1]

I really think you should try to minimize the code duplication as much as possible.

Could you take a look at my revision of your branch, where I remove the need for createAttributesV2 in the first place? I.e., I made your code work with prompb.Label instead to be compatible with the RW v1 code.

If you duplicate all the code between RW v1 and v2 it's going to be really painful to maintain.

[jmichalek132]

I really think you should try to minimize the code duplication as much as possible.

Could you take a look at my revision of your branch, where I remove the need for createAttributesV2 in the first place? I.e., I made your code work with prompb.Label instead to be compatible with the RW v1 code.

If you duplicate all the code between RW v1 and v2 it's going to be really painful to maintain.

Thank you for the suggestion I will implement your suggested changes.

[ArthurSens]

Nice work, this is looking a lot better :)

Some extra comments. 👇

[aknuds1]

LGTM

[dashpole]

Seems like CI was broken

 Error: elasticsearchexporter/bulkindexer_test.go:302:4: encoded-compare: use assert.JSONEq (testifylint)
			assert.Equal(t, "{\"create\":{\"_index\":\"foo\"}}\n{\"foo\": \"bar\"}\n", records[1].ContextMap()["request_body"])

Hopefully fixed by #35900