[receiver/tlscheck] Implement Scraper #35823
Open
+379
−316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-burt
force-pushed
the
tlscheckreceiver
branch
from
7021957 to
7e2efe8
Compare
michael-burt
force-pushed
the
tlscheckreceiver
branch
2 times, most recently
from
e70cc3d to
04e76eb
Compare
michael-burt
force-pushed
the
tlscheckreceiver
branch
2 times, most recently
from
2863b29 to
05448b6
Compare
michael-burt
force-pushed
the
tlscheckreceiver
branch
from
1b1c149 to
349749a
Compare
michael-burt
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
TylerHelmuth,
yurishkuro,
mx-psi and
bogdandrutu
as code owners
JaredTan95
approved these changes
Nov 20, 2024
|
@michael-burt conflicts that need to be resolved~ |
dehaansa
approved these changes
Nov 25, 2024
dmitryax
reviewed
Nov 26, 2024
dmitryax
reviewed
Nov 26, 2024
Comment on lines
+14
to
+17
| tlscheck.endpoint: | ||
| enabled: true | ||
| description: Endpoint at which the certificate was accessed. | ||
| type: string |
There was a problem hiding this comment.
Why is this moved from resource attributes? It still seems like a resource attribute.
dmitryax
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the scraper functionality of this receiver. It supports one or more host-based checks which are executed in parallel.
Link to tracking issue
Fixes #35842
Testing
This includes tests for both valid and invalid certs.
Documentation