[receiver/webhookevent] Pass error to EndLogsOp #35844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
webhooks-bug-fix
branch
from
08b17d9 to
e7b6101
Compare
|
@atoulme can you take a look here? |
narcis96
added a commit
to Huawei-IRC-Cloud-Telemetry-Engineering/opentelemetry-collector-contrib
that referenced
this pull request
Oct 30, 2024
#48) #### Description I noticed that we're not passing the error to `EndLogsOp`. This can cause inaccurate metrics in internal observability. This PR fixes it. Co-authored-by: VihasMakwana <[email protected]>
zzhlogin
pushed a commit
to zzhlogin/opentelemetry-collector-contrib-aws
that referenced
this pull request
Nov 12, 2024
#### Description I noticed that we're not passing the error to `EndLogsOp`. This can cause inaccurate metrics in internal observability. This PR fixes it.
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description I noticed that we're not passing the error to `EndLogsOp`. This can cause inaccurate metrics in internal observability. This PR fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that we're not passing the error to
EndLogsOp. This can cause inaccurate metrics in internal observability.This PR fixes it.