[chore] Make TestReadRotatingFiles more robust on Windows #36032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
changed the title
…ithub.com:pjanotti/opentelemetry-service-contrib into make-TestReadRotatingFiles-more-robust-on-Windows
atoulme
approved these changes
Oct 29, 2024
dmitryax
approved these changes
Oct 29, 2024
pjanotti
deleted the
make-TestReadRotatingFiles-more-robust-on-Windows
branch
zzhlogin
pushed a commit
to zzhlogin/opentelemetry-collector-contrib-aws
that referenced
this pull request
Nov 12, 2024
…etry#36032) Make the remove operation an "eventually required" since on Windows you can't delete if there are still handles opened to the file. This should prevent failures like https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11559461472/job/32174166127#step:8:259 see below. On my box multiple runs were failing but that higher frequency of failures was probably to the usage of antivirus software, this change made it to pass consistently on my box. ```terminal D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 600s -parallel 4 --tags="" ✖ . (1.777s) === Failed === FAIL: . TestReadRotatingFiles/CopyTruncate (2.73s) filelog_test.go:194: Error Trace: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/filelogreceiver/filelog_test.go:194 Error: Received unexpected error: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatingFilesCopyTruncate3537600095\001\test-backup.log: The process cannot access the file because it is being used by another process. Test: TestReadRotatingFiles/CopyTruncate === FAIL: . TestReadRotatingFiles (0.00s) === FAIL: . TestReadRotatingFiles/CopyTruncate (re-run 1) (1.63s) filelog_test.go:194: Error Trace: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/filelogreceiver/filelog_test.go:194 Error: Received unexpected error: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatingFilesCopyTruncate134417[272](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11559461472/job/32174166127#step:8:273)3\001\test-backup.log: The process cannot access the file because it is being used by another process. Test: TestReadRotatingFiles/CopyTruncate === FAIL: . TestReadRotatingFiles (re-run 1) (0.00s) ```
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…etry#36032) Make the remove operation an "eventually required" since on Windows you can't delete if there are still handles opened to the file. This should prevent failures like https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11559461472/job/32174166127#step:8:259 see below. On my box multiple runs were failing but that higher frequency of failures was probably to the usage of antivirus software, this change made it to pass consistently on my box. ```terminal D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 600s -parallel 4 --tags="" ✖ . (1.777s) === Failed === FAIL: . TestReadRotatingFiles/CopyTruncate (2.73s) filelog_test.go:194: Error Trace: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/filelogreceiver/filelog_test.go:194 Error: Received unexpected error: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatingFilesCopyTruncate3537600095\001\test-backup.log: The process cannot access the file because it is being used by another process. Test: TestReadRotatingFiles/CopyTruncate === FAIL: . TestReadRotatingFiles (0.00s) === FAIL: . TestReadRotatingFiles/CopyTruncate (re-run 1) (1.63s) filelog_test.go:194: Error Trace: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/filelogreceiver/filelog_test.go:194 Error: Received unexpected error: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatingFilesCopyTruncate134417[272](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11559461472/job/32174166127#step:8:273)3\001\test-backup.log: The process cannot access the file because it is being used by another process. Test: TestReadRotatingFiles/CopyTruncate === FAIL: . TestReadRotatingFiles (re-run 1) (0.00s) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the remove operation an "eventually required" since on Windows you can't delete if there are still handles opened to the file. This should prevent failures like https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11559461472/job/32174166127#step:8:259 see below.
On my box multiple runs were failing but that higher frequency of failures was probably to the usage of antivirus software, this change made it to pass consistently on my box.