Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][connector/routing] Refactor trace and metric routing by resource #36098

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

djaglowski
Copy link
Member

This PR refactors routing traces:

  • Add an internal ptraceutil package which helps separate traces based on a matching function.
  • Split processing path based on match_once
  • When match_once is false, use the same logic as before.
  • When match_once is true, use the new ptraceutil package.

This also includes a few minor changes to style and function names to ensure the updated traces code is closely aligned with the recently updated logs code.

Depends on #36097

@djaglowski djaglowski force-pushed the routing-split-paths2 branch from 9ae2bc1 to 9d5a3ab Compare November 1, 2024 22:38
@djaglowski djaglowski changed the title [chore][connector/routing] Refactor [chore][connector/routing] Refactor trace and metric routing by resource Nov 1, 2024
@djaglowski djaglowski marked this pull request as ready for review November 1, 2024 22:53
@djaglowski djaglowski requested a review from a team as a code owner November 1, 2024 22:53
@djaglowski djaglowski merged commit eac16d3 into open-telemetry:main Nov 1, 2024
160 checks passed
@djaglowski djaglowski deleted the routing-split-paths2 branch November 1, 2024 23:25
@github-actions github-actions bot added this to the next release milestone Nov 1, 2024
ArthurSens pushed a commit to ArthurSens/opentelemetry-collector-contrib that referenced this pull request Nov 4, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants