[chore][connector/routing] Refactor metric test examples into code #36149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
routing-pdatagen
branch
from
d4637cc to
1b71f26
Compare
djaglowski
force-pushed
the
routing-pdatagen
branch
from
86197bb to
1b71f26
Compare
djaglowski
force-pushed
the
routing-pdatagen
branch
from
1b71f26 to
f9e8c0b
Compare
atoulme
approved these changes
Nov 3, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR condenses code for testing metrics. Initially, the test suite was designed to accommodate any arbitrary inputs and outputs, but at this point it seems clear we can validate the necessary functionality much more concisely. To that end, this PR adds a simple
pmetricutiltestpackage which replaces thousands of lines of example files. This same pattern should work for traces and logs as well.