Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/jsonlogencoding] Support marshaling multiple logs #36156

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Nov 3, 2024

Description

Change how logs are marshaled. Instead of marshaling just the first log, marshal all logs into a JSON array.

Link to tracking issue

Fixes #34064

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 26, 2024
@VihasMakwana
Copy link
Contributor

@atoulme looks good to be merged once you resolve conflicts.

@github-actions github-actions bot removed the Stale label Nov 27, 2024
@atoulme atoulme force-pushed the consume_multiple_records branch from 43183ef to 866879a Compare December 10, 2024 19:30
@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Dec 11, 2024
@MovieStoreGuy MovieStoreGuy merged commit 421d710 into open-telemetry:main Dec 11, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 11, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…lemetry#36156)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Change how logs are marshaled. Instead of marshaling just the first log,
marshal all logs into a JSON array.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#34064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/encoding ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonlogencoding only handles the first log record's body of the pdata logs payload
5 participants