Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[chore][testbed] - Further testbed enhancements" #36266

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Revert "[chore][testbed] - Further testbed enhancements" #36266

merged 1 commit into from
Nov 7, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Nov 7, 2024

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 7, 2024
@songy23 songy23 requested a review from a team as a code owner November 7, 2024 20:17
@songy23 songy23 requested a review from ChrsMark November 7, 2024 20:17
VihasMakwana
VihasMakwana approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@VihasMakwana VihasMakwana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the CI was green on my PR.

I will reraise it again after making necessary changes.

Sorry for inconvenience

@songy23
Copy link
Member Author

songy23 commented Nov 7, 2024

@VihasMakwana no worries, it is probably a merge conflict

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Nov 7, 2024
@TylerHelmuth TylerHelmuth merged commit 4b1ca00 into main Nov 7, 2024
172 of 174 checks passed
@TylerHelmuth TylerHelmuth deleted the revert-35209-memorylimit-test-cases branch November 7, 2024 20:47
@github-actions github-actions bot added this to the next release milestone Nov 7, 2024
@songy23 songy23 mentioned this pull request Nov 7, 2024
Merged
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@songy23 @sbylica-splunk
Revert "[chore][testbed] - Further testbed enhancements" (open-teleme…
94fbba1 
…try#36266)

Reverts open-telemetry#35209

Breaks mainline:
https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11727234196/job/32667863492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdrutu sfc-gh-bdrutu sfc-gh-bdrutu approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codeboten codeboten codeboten approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@dashpole dashpole

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry testbed
Projects
None yet
Milestone
v0.114.0
Development

Successfully merging this pull request may close these issues.
7 participants
@songy23 @codeboten @bogdandrutu @TylerHelmuth @VihasMakwana @sfc-gh-bdrutu @dashpole