Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add more labels to the labels action #36344

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[chore] Add more labels to the labels action #36344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/scripts/add-labels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ COMMON_LABELS["needs-triage"]="needs triage"
COMMON_LABELS["os:mac"]="os:mac"
COMMON_LABELS["os:windows"]="os:windows"
COMMON_LABELS["waiting-for-author"]="waiting for author"
COMMON_LABELS["waiting-for-code-owners"]="waiting-for-code-owners"
COMMON_LABELS["bug"]="bug"
COMMON_LABELS["priority:p0"]="priority:p0"
COMMON_LABELS["priority:p1"]="priority:p1"
COMMON_LABELS["priority:p2"]="priority:p2"
COMMON_LABELS["priority:p3"]="priority:p3"
COMMON_LABELS["stale"]="Stale"
COMMON_LABELS["never-stale"]="never stale"

LABELS=$(echo "${COMMENT}" | sed -E 's%^/label%%')

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scripts/ping-codeowners-issues.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ if [[ -z "${OWNERS}" ]]; then
exit 0
fi

gh issue comment "${ISSUE}" --body "Pinging code owners for ${COMPONENT}: ${OWNERS}. See [Adding Labels via Comments](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-labels-via-comments) if you do not have permissions to add labels yourself."
gh issue comment "${ISSUE}" --body "Pinging code owners for ${COMPONENT}: ${OWNERS}. See [Adding Labels via Comments](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-labels-via-comments) if you do not have permissions to add labels yourself. For example, comment '/label priority:p2 -needs-triaged' to set the priority and remove the needs-triaged label."
28 changes: 18 additions & 10 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,16 +342,24 @@ In order to facilitate proper label usage and to empower Code Owners, you are ab

The following general labels are supported:

| Label | Label in Comment |
|----------------------|----------------------|
| `arm64` | `arm64` |
| `good first issue` | `good-first-issue` |
| `help wanted` | `help-wanted` |
| `discussion needed` | `discussion-needed` |
| `needs triage` | `needs-triage` |
| `os:mac` | `os:mac` |
| `os:windows` | `os:windows` |
| `waiting for author` | `waiting-for-author` |
| Label | Label in Comment |
|---------------------------|---------------------------|
| `arm64` | `arm64` |
| `good first issue` | `good-first-issue` |
| `help wanted` | `help-wanted` |
| `discussion needed` | `discussion-needed` |
| `needs triage` | `needs-triage` |
| `os:mac` | `os:mac` |
| `os:windows` | `os:windows` |
| `waiting for author` | `waiting-for-author` |
| `waiting-for-code-owners` | `waiting-for-code-owners` |
| `bug` | `bug` |
| `priority:p0` | `priority:p0` |
| `priority:p1` | `priority:p1` |
| `priority:p2` | `priority:p2` |
| `priority:p3` | `priority:p3` |
| `Stale` | `stale` |
| `never stale` | `never-stale` |

To delete a label, prepend the label with `-`. Note that you must make a new comment to modify labels; you cannot edit an existing comment.

Expand Down