[chore][internal/k8stest] Make k8stest package publicly available #36661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
requested review from
andrzej-stencel,
Aneurysm9,
ankitpatel96,
atoulme,
carsonip and
ChrsMark
jade-guiton-dd
approved these changes
Dec 4, 2024
povilasv
approved these changes
Dec 4, 2024
TylerHelmuth
previously requested changes
Dec 5, 2024
Sure, let's discuss. I opened this PR just to visualize what I am proposing. |
odubajDT
force-pushed
the
internal-to-pkg
branch
from
8df0b90 to
b0cb0cd
Compare
odubajDT
force-pushed
the
internal-to-pkg
branch
from
0c31374 to
43cf2de
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
not stale |
odubajDT
force-pushed
the
internal-to-pkg
branch
from
fc687df to
129c5e9
Compare
odubajDT
force-pushed
the
internal-to-pkg
branch
from
129c5e9 to
66fee7a
Compare
TylerHelmuth
dismissed
their stale review
unblocking based on discussion in issue
odubajDT
force-pushed
the
internal-to-pkg
branch
from
66fee7a to
74dc5fe
Compare
mx-psi
approved these changes
Jan 14, 2025
odubajDT
force-pushed
the
internal-to-pkg
branch
from
b4da7b2 to
a4c2989
Compare
ChrsMark
approved these changes
Jan 16, 2025
odubajDT
force-pushed
the
internal-to-pkg
branch
from
a4c2989 to
aa94ee3
Compare
odubajDT
force-pushed
the
internal-to-pkg
branch
2 times, most recently
from
15b2a9c to
db0e6a5
Compare
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
internal-to-pkg
branch
from
db0e6a5 to
3baafc0
Compare
|
@andrzej-stencel would you be willing to merge this as well? Thank you! |
andrzej-stencel
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I see there are some functional changes to the CreateCollectorObjects method. Ideally they should be done in a separate pull request, but I'm willing to let this pass. Probably better to introduce the breaking changes before the module is public, even if there are no stability guarantees on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Part of #36615