-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChrsMark in k8s components code-owners #36703
Merged
mx-psi
merged 7 commits into
open-telemetry:main
from
ChrsMark:add_k8s_components_ownership
Dec 10, 2024
Merged
Add ChrsMark in k8s components code-owners #36703
mx-psi
merged 7 commits into
open-telemetry:main
from
ChrsMark:add_k8s_components_ownership
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
requested review from
dmitryax,
TylerHelmuth,
a team and
fatsheep9146
as code owners
December 6, 2024 10:14
github-actions
bot
added
processor/k8sattributes
k8s Attributes processor
receiver/k8scluster
receiver/k8sevents
receiver/k8sobjects
labels
Dec 6, 2024
povilasv
approved these changes
Dec 6, 2024
frzifus
approved these changes
Dec 6, 2024
codeboten
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Pinging @dmitryax @TylerHelmuth
TylerHelmuth
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also kubeletstats
atoulme
approved these changes
Dec 6, 2024
@TylerHelmuth That's already the case :)
|
TylerHelmuth
approved these changes
Dec 6, 2024
andrzej-stencel
approved these changes
Dec 9, 2024
songy23
approved these changes
Dec 9, 2024
songy23
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Dec 9, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
Based on our discussion with @TylerHelmuth I'm proposing to formally get involved more with the following k8s components: - k8scluster receiver - k8sobjects receiver - k8sevents receiver - k8sattributes processor I have been actively following and reviewing the evolution of these components while also being involved in the [K8s SemConv approvers team](https://github.com/orgs/open-telemetry/teams/semconv-k8s-approvers). Being also involved in the stability work of K8s SemConv will help bridge the gaps more easily. Some related work: - PRs reviewed: [https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+[…]2Fk8sobjects%2Creceiver%2Fk8sevents%2Cprocessor%2Fk8sattributes](https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+reviewed-by%3AChrsMark+label%3Areceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents%2Cprocessor%2Fk8sattributes) - PRs authored: [https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+[…]ver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents](https://github.com/open-telemetry/opentelemetry-collector-contrib/pulls?q=is%3Apr+author%3AChrsMark+label%3Aprocessor%2Fk8sattributes%2Creceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents) - Issues created: [https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Ais[…]er%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aissue+author%3AChrsMark+label%3Aprocessor%2Fk8sattributes%2Creceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+) - Issues commented: [https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Ais[…]er%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+](https://github.com/open-telemetry/opentelemetry-collector-contrib/issues?q=is%3Aissue+commenter%3AChrsMark+label%3Aprocessor%2Fk8sattributes%2Creceiver%2Fk8scluster%2Creceiver%2Fk8sobjects%2Creceiver%2Fk8sevents+) Signed-off-by: ChrsMark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
processor/k8sattributes
k8s Attributes processor
ready to merge
Code review completed; ready to merge by maintainers
receiver/k8scluster
receiver/k8sevents
receiver/k8sobjects
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussion with @TylerHelmuth I'm proposing to formally get involved more with the following k8s components:
I have been actively following and reviewing the evolution of these components while also being involved in the K8s SemConv approvers team. Being also involved in the stability work of K8s SemConv will help bridge the gaps more easily.
Some related work: