-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove max_in_flight_size_mib option #36707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heidmotron
changed the title
Remove max_in_flight_size_mib option
[chore] Remove max_in_flight_size_mib option
Dec 7, 2024
Codeowners please review? |
moh-osman3
approved these changes
Dec 12, 2024
atoulme
approved these changes
Dec 14, 2024
atoulme
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Dec 14, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description Removes `max_in_flight_size_mib` in the Readme since it has been replaced by `admission` settings in the otelarrow receiver. Opted not to add the `admission` options since the config was focused on the exporter/processor but feel free to close if that's the better route. Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
#### Description Removes `max_in_flight_size_mib` in the Readme since it has been replaced by `admission` settings in the otelarrow receiver. Opted not to add the `admission` options since the config was focused on the exporter/processor but feel free to close if that's the better route. Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
max_in_flight_size_mib
in the Readme since it has been replaced byadmission
settings in the otelarrow receiver.Opted not to add the
admission
options since the config was focused on the exporter/processor but feel free to close if that's the better route.