Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove max_in_flight_size_mib option #36707

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

heidmotron
Copy link
Contributor

@heidmotron heidmotron commented Dec 6, 2024

Description

Removes max_in_flight_size_mib in the Readme since it has been replaced by admission settings in the otelarrow receiver.

Opted not to add the admission options since the config was focused on the exporter/processor but feel free to close if that's the better route.

@heidmotron heidmotron requested review from jmacd and a team as code owners December 6, 2024 16:23
@heidmotron heidmotron changed the title Remove max_in_flight_size_mib option [chore] Remove max_in_flight_size_mib option Dec 7, 2024
@atoulme
Copy link
Contributor

atoulme commented Dec 10, 2024

Codeowners please review?

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Dec 14, 2024
@andrzej-stencel andrzej-stencel merged commit be56910 into open-telemetry:main Dec 16, 2024
141 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 16, 2024
@heidmotron heidmotron deleted the patch-2 branch December 17, 2024 07:17
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
#### Description
Removes `max_in_flight_size_mib` in the Readme since it has been
replaced by `admission` settings in the otelarrow receiver.

Opted not to add the `admission` options since the config was focused on
the exporter/processor but feel free to close if that's the better
route.

Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Andrzej Stencel <[email protected]>
mterhar pushed a commit to mterhar/opentelemetry-collector-contrib that referenced this pull request Dec 19, 2024
#### Description
Removes `max_in_flight_size_mib` in the Readme since it has been
replaced by `admission` settings in the otelarrow receiver.

Opted not to add the `admission` options since the config was focused on
the exporter/processor but feel free to close if that's the better
route.

Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/otelarrow ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants