Adding status code handler to clients #36716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name (#3) * Add option to override cluster name
#4) [receiver/awscontainerinsightreceiver] Parameterize EKS CI leader lock name
Skip flaky test (cherry picked from commit 14983a6)
Getting 404s when trying to run apt update w/ debian 9 --------- Signed-off-by: Alex Boten <[email protected]> (cherry picked from commit 80069fb)
…r name as a metric label
…maps as EKS leader election lock resource
…a wrapped SimplePrometheusReceiver
…ics for capacity_pods, allocatable_pods and conditions (#17)
…heus_poc Initial commit of prometheus scraper for pulling control plane metrics from k8sapiserver prometheus endpoint
Paramadon
requested review from
fatsheep9146,
jpkrohling,
TylerHelmuth,
ChrsMark,
yurishkuro,
codeboten,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
mwear,
jsuereth and
songy23
as code owners
|
|
github-actions
bot
added
cmd/githubgen
cmd/opampsupervisor
cmd/otelcontribcol
yurishkuro
reviewed
Dec 9, 2024
songy23
reviewed
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Background
As part of our ongoing efforts to improve the monitoring and observability of our API calls, we have a COE action item to ensure that all API call status codes are captured and tracked. This is crucial to help identify and resolve any issues proactively. Currently, the agenthealth middleware, which has already been developed, is not integrated into all of our clients.
Agent health extension pr: aws/amazon-cloudwatch-agent#1423
Agent changes pr: aws/amazon-cloudwatch-agent#1442
Overview of Changes
This pull request addresses the integration of the
agenthealthmiddleware into all relevant clients in thecontribrepository. Specifically, this change is focused on the following components:These components are central to our monitoring pipeline, and by adding the
agenthealthmiddleware to them, we ensure that all API calls made within these parts of the codebase are monitored for status codes. This will help us track the health and performance of the services that these components interact with, providing valuable insights into potential issues.Details of Changes
Middleware Integration: The
agenthealthmiddleware has been added to the API clients used within theResourceDetectionProcessor,ContainerInsightReceiver, and the variousExporters. This middleware is responsible for capturing and logging the status codes of all API requests, allowing for better tracking and troubleshooting of potential issues.Improved Observability: With the middleware in place, we now have enhanced visibility into the performance and reliability of the APIs we interact with. This change will help surface any unexpected issues, such as 5xx server errors or 4xx client errors, allowing for faster identification and resolution of problems.
Consistency: The integration of this middleware across multiple components ensures that monitoring is consistent throughout the system, and all API calls are tracked uniformly, eliminating gaps in observability.
Impact
Enhanced Monitoring: By adding the agenthealth middleware, this change improves our ability to detect and monitor API errors across the system, ensuring better visibility into issues with external services.
Proactive Issue Detection: The ability to monitor status codes enables us to identify and address issues before they impact users, improving the reliability and stability of the system.
Consistency Across Components: With the integration of this middleware across multiple clients, we ensure that all parts of the system are monitored in a standardized way, leading to a more cohesive monitoring strategy.