Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix check-codeowners: path needs to be updated on its own step #36732

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Dec 9, 2024

Path for the tool needs to be updated on its own step, prior to using the tool.

@pjanotti
Copy link
Contributor Author

pjanotti commented Dec 9, 2024

The check-owners is going to fail since it comes from main not from the changes in this PR...

@pjanotti pjanotti marked this pull request as ready for review December 9, 2024 21:02
@pjanotti pjanotti requested a review from a team as a code owner December 9, 2024 21:02
@pjanotti pjanotti requested a review from fatsheep9146 December 9, 2024 21:02
@atoulme
Copy link
Contributor

atoulme commented Dec 10, 2024

That didn't seem to do it. What changed?

@codeboten codeboten merged commit ca10fa7 into open-telemetry:main Dec 10, 2024
161 of 164 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 10, 2024
@pjanotti pjanotti deleted the fix-missing-githubgen-in-check-codeowners branch December 10, 2024 18:34
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
open-telemetry#36732)

Path for the tool needs to be updated on its own step, prior to using
the tool.
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Jan 13, 2025
open-telemetry#36732)

Path for the tool needs to be updated on its own step, prior to using
the tool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants