Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][lint]: Replace exportloopref with copyloopvar for golangci-lint 1.62 #36800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rockdaboot
Copy link
Contributor

Description

Fix a warning with golangci-lint 1.62 about using the deprecated linter exportloopref.

Link to tracking issue

Related: #36638

@rockdaboot rockdaboot requested a review from a team as a code owner December 12, 2024 11:37
@rockdaboot rockdaboot requested a review from ChrsMark December 12, 2024 11:37
@rockdaboot
Copy link
Contributor Author

This change pulls in another set of required changes for #36638.
Alternatively, drop the exportloopref linter without replacement.

@atoulme
Copy link
Contributor

atoulme commented Dec 17, 2024

Do you want to fix the linting errors reported? You can also elect to open issues per component. Thanks for the help!

@rockdaboot
Copy link
Contributor Author

Do you want to fix the linting errors reported? You can also elect to open issues per component. Thanks for the help!

We can either simply drop exportloopref or replace it with copyloopvar and fix the linter warnings. The second is very tedious if done as one PR per component, while a script can fix everything in one wash.

Just would like to get general consensus on this before doing anything.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants