Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] [chore] Drop strftime dependency #36810

Conversation

rockdaboot
Copy link
Contributor

Description

Switch to Go style time format strings:

  • drop strftime dependency
  • simplify code

@rockdaboot rockdaboot force-pushed the elasticsearchexporter-drop-strftime branch from e83c552 to 8791ff6 Compare December 12, 2024 18:14
Copy link
Contributor

@carsonip carsonip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking change IIUC. It is both changing the default, and the expected format of the input config.

date_format(default=%Y.%m.%d): Time format (based on strftime) to generate the second part of the Index name.

Do you expect an existing config file with date_format: %Y.%m.%d to work after this change?

@rockdaboot
Copy link
Contributor Author

Do you expect an existing config file with date_format: %Y.%m.%d to work after this change?

Oh I see 😅. I didn't follow the code-as-string pattern which leads to date_format as part of logstash_format, which is documented in README.md. My lack of understanding the higher level concepts here.

Does it make sense to add prefix_separator and date_format to testdata/config.yaml to make it more obvious that these fields are user-facing?

@rockdaboot rockdaboot closed this Dec 16, 2024
@rockdaboot rockdaboot deleted the elasticsearchexporter-drop-strftime branch December 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants