[jaegerreceiver] Remove ineffectual warning log #36831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
dmitryax
approved these changes
Dec 14, 2024
songy23
reviewed
Dec 16, 2024
Co-authored-by: Yang Song <[email protected]>
|
Needs |
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36831 +/- ##
==========================================
- Coverage 79.72% 79.71% -0.01%
==========================================
Files 2218 2218
Lines 209156 209150 -6
==========================================
- Hits 166747 166726 -21
- Misses 36833 36845 +12
- Partials 5576 5579 +3 ☔ View full report in Codecov by Sentry. |
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description The remote sampling functionality has been already removed from `jaegerreceiver` in open-telemetry#14163. The logged warning has no impact or meaning. #### Link to tracking issue Fixes open-telemetry#35894 #### Testing CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yang Song <[email protected]>
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
The remote sampling functionality has been already removed from `jaegerreceiver` in open-telemetry#14163. The logged warning has no impact or meaning. Fixes open-telemetry#35894 CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yang Song <[email protected]>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
#### Description The remote sampling functionality has been already removed from `jaegerreceiver` in open-telemetry#14163. The logged warning has no impact or meaning. #### Link to tracking issue Fixes open-telemetry#35894 #### Testing CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remote sampling functionality has been already removed from
jaegerreceiverin #14163. The logged warning has no impact or meaning.Link to tracking issue
Fixes #35894
Testing
CI